[PATCH] D156398: [AMDGPU] Remove post-PromoteAlloca SROA run
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 1 16:52:45 PDT 2023
arsenm added a comment.
In D156398#4541401 <https://reviews.llvm.org/D156398#4541401>, @Pierre-vh wrote:
> @arsenm There is a crash in `amdgpu_isel.test` from `check-llvm-tools-updatetestchecks`
> This function fails ISel:
>
> ; RUN: llc -mtriple=amdgcn-amd-amdhsa -stop-after=finalize-isel -debug-only=isel -o /dev/null %s 2>&1 | FileCheck %s
>
> define i64 @i64_test(i64 %i) nounwind readnone {
> %loc = alloca i64
> %j = load i64, i64 * %loc
> %r = add i64 %i, %j
> ret i64 %r
> }
This test is just broken. It's using the wrong address space for the alloca and sroa just happened to delete it. Also this should use opaque pointers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156398/new/
https://reviews.llvm.org/D156398
More information about the llvm-commits
mailing list