[PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin
Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 1 12:10:15 PDT 2023
RamNalamothu updated this revision to Diff 546173.
RamNalamothu added a comment.
Herald added subscribers: luke, frasercrmck, sameer.abuasal, Jim, jocewei, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, johnrusso, rbar.
Added RISC-V specific test which overrides MCInstrAnalysis methods and uses the newly added code path.
Tests in `lldb/unittests/Disassembler/x86/TestGetControlFlowKindx86.cpp` use MCInstrAnalysis default methods and need old behavior before this patch.
Tests in `lldb/unittests/Disassembler/RISCV/TestMCDisasmInstanceRISCV.cpp` use RISC-V overridden MCInstrAnalysis methods and need new behavior from this patch.
Does this look good now?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156086/new/
https://reviews.llvm.org/D156086
Files:
lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
lldb/unittests/Disassembler/CMakeLists.txt
lldb/unittests/Disassembler/RISCV/CMakeLists.txt
lldb/unittests/Disassembler/RISCV/TestMCDisasmInstanceRISCV.cpp
lldb/unittests/Disassembler/x86/TestGetControlFlowKindx86.cpp
llvm/include/llvm/MC/MCInstrAnalysis.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156086.546173.patch
Type: text/x-patch
Size: 10342 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230801/a66655a0/attachment.bin>
More information about the llvm-commits
mailing list