[PATCH] D156796: [ADT] [NFC] Introduce isLower and isUpper helpers.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 11:23:14 PDT 2023


jhenderson accepted this revision.
jhenderson added a comment.

LGTM. I'd add the unit test, but I'm not going to push strongly for it.



================
Comment at: llvm/include/llvm/ADT/StringExtras.h:104
+
+/// Checks if character \p C is a uppercase letter as classified by "C" locale.
+inline bool isUpper(char C) { return 'A' <= C && C <= 'Z'; }
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156796/new/

https://reviews.llvm.org/D156796



More information about the llvm-commits mailing list