[PATCH] D149895: [SystemZ][z/OS] Remove ENDRecord class from GOFF.h

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added a comment.

In D149895#4425105 <https://reviews.llvm.org/D149895#4425105>, @Everybody0523 wrote:

> Anything the ENDRecord does can be easily handled by the parent Record class.
>
> The ENDRecord class only has two functions, `getNameLength` is just a wrapper for `get<T>()` in the parent class (defined here <https://llvm.org/docs/doxygen/Object_2GOFF_8h_source.html>) and `getData()` is likewise a basically just a wrapper for `getContinuousData()`, also defined in the parent class.

There are seven different fields in the END record. Having END cards be the only record type that requires callers to unpack the record manually doesn't seem like good design.

And the class is only dead because it hasn't been connected yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149895/new/

https://reviews.llvm.org/D149895