[PATCH] D156773: Increase performance of llvm-gsymutil by up to 200%.

[jeffrey tan via Phabricator via llvm-commits]

yinghuitan accepted this revision.
yinghuitan added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/DebugInfo/GSYM/GsymCreator.cpp:248
+            // the sort.
+            if (!(Prev == Curr)) {
+              if (Prev.hasRichInfo() && Curr.hasRichInfo()) {
----------------
Nit: `Prev != Curr`


================
Comment at: llvm/lib/DebugInfo/GSYM/GsymCreator.cpp:272
+        } else {
+          if (Prev.Range.size() == 0 && Curr.Range.contains(Prev.Range.start())) {
+            if (!Quiet) {
----------------
Nit: `Prev.Range.empty()`? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156773/new/

https://reviews.llvm.org/D156773