[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 1 09:01:30 PDT 2023
MaskRay added inline comments.
================
Comment at: clang/include/clang/Driver/Options.td:2955
+ MarshallingInfoFlag<CodeGenOpts<"AllTocData">>;
+def mno_tocdata_EQ : CommaJoined<["-"], "mno-tocdata=">,
+ Flags<[CC1Option,TargetSpecific]>,
----------------
If `-mtocdata=` is opt-in, the convention is to make just `-mtocdata=` CC1Option, but clear the flag for `-mno-tocdata=`.
================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:455
+
+ llvm::StringSet<> ExplicitlySpecifiedGlobals;
+ for (const auto Arg : Args.filtered(options::OPT_mtocdata_EQ,
----------------
StringSet has non-deterministic iteration order. Ensure that the behavior doesn't change :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153907/new/
https://reviews.llvm.org/D153907
More information about the llvm-commits
mailing list