[PATCH] D156715: [CSSPGO] Fix issues with post-link function checksum check

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

How does perf look like after disabling annotating imported functions?



================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1825
+      LLVM_DEBUG(dbgs() << "There is no probe_desc for " << F.getName()
+                        << " or it's an external function."
+                        << "\n");
----------------
nit: external -> imported


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2279
+    const auto *FuncDesc = ProbeManager->getDesc(F);
+    if (FuncDesc && ProbeManager->profileIsHashMismatched(*FuncDesc, FS)) {
       MismatchedFuncHashSamples += Count;
----------------
Can we assert `FuncDesc` to be non-null here? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156715/new/

https://reviews.llvm.org/D156715