[PATCH] D156782: [AMDGPU] Test disassembling of some basic True16 VOP2 instructions.

Tue Aug 1 08:16:00 PDT 2023

kosarev added inline comments.

================
Comment at: llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop2.txt:2
+# RUN: llvm-mc -arch=amdgcn -mcpu=gfx1100 -mattr=-real-true16 -disassemble -show-encoding < %s | FileCheck -check-prefixes=GFX11,W32,GFX11-FAKE16 %s
+# RUN: llvm-mc -arch=amdgcn -mcpu=gfx1100 -mattr=+real-true16 -disassemble -show-encoding < %s | FileCheck -check-prefixes=GFX11,W32,GFX11-REAL16 %s
 # RUN: llvm-mc -arch=amdgcn -mcpu=gfx1100 -mattr=-WavefrontSize32,+WavefrontSize64 -disassemble -show-encoding < %s | FileCheck -check-prefixes=GFX11,W64 %s
----------------
Joe_Nash wrote:
> I think we should use the same naming paradigm and workflow for CHECK names as in the codegen tests. To match codegen, it would make -mattr=+real-true16 tests are called 'GFX11'. There is an argument to do the naming the other way, where '-mattr=-real-true16' continues to be GFX11. Both are fine from my PoV; perhaps the choice should me made to minimize merge pain.
> To match codegen, it would make -mattr=+real-true16 tests are called 'GFX11'.

That was my aim, but in this particular test GFX11 is used as a common prefix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156782/new/

https://reviews.llvm.org/D156782