[PATCH] D156793: [TailCallElim] Remove the readonly attribute of byval.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 07:42:31 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM, but maybe wait a day before committing in case somebody disagrees with this approach.

I would also recommend to add a PhaseOrdering test for https://github.com/llvm/llvm-project/issues/64289. This miscompile here is due to an interaction of multiple passes, so I think it's worthwhile to check the full optimization pipeline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156793/new/

https://reviews.llvm.org/D156793



More information about the llvm-commits mailing list