[PATCH] D156502: [TableGen][NFC] Group tokens with same attribute togather

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 06:57:52 PDT 2023

wangpc marked 3 inline comments as done.
wangpc added a comment.

In D156502#4549969 <https://reviews.llvm.org/D156502#4549969>, @fpetrogalli wrote:

> This LGTM, thanks.
> I have noticed that the "unclustered" values are still not grouped together. I thought it was a matter of just the few I mentioned in my first comment but apparently there are more.
> I would have ordered the enum as { unclustered, group1, group2, ....}, just because it would have make it easier to find the cluster. But this is really debatable as it is my personal preference, no need to change it if you do not want to.
> Thanks!
> Francesco

Yeah I agree with you!

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list