[PATCH] D156713: [AMDGPU] Add target features for GDS and GWS

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D156713#4549959 <https://reviews.llvm.org/D156713#4549959>, @AlexVlx wrote:

> In D156713#4549890 <https://reviews.llvm.org/D156713#4549890>, @foad wrote:
>
>> In D156713#4547539 <https://reviews.llvm.org/D156713#4547539>, @b-sumner wrote:
>>
>>> In D156713#4547505 <https://reviews.llvm.org/D156713#4547505>, @arsenm wrote:
>>>
>>>> In D156713#4547504 <https://reviews.llvm.org/D156713#4547504>, @b-sumner wrote:
>>>>
>>>>> In D156713#4547434 <https://reviews.llvm.org/D156713#4547434>, @foad wrote:
>>>>>
>>>>>> Do we want a separate GWS feature? Or a combined "hasGDSAndGWS" feature?
>>>>>
>>>>> We do need a feature that include GWS.  GDS was dropped before GWS in GFX9, but compute never used GDS.  So GDSandGWS would probably work.
>>>>
>>>> I didn't realize GDS was dropped in gfx9, should split the two then
>>>
>>> Sorry for mangling this.  GDS was dropped in gfx90a.  GWS was not dropped in gfx9.
>>
>> What about gfx909 and gfx90c?
>>
>> In the current patch I have assumed gfx908 and gfx909 both have GDS, and gfx90a and gfx90c (and gfx94x) lack it.
>
> Somewhat confusingly, gfx90c is an older APU (Renoir IIRC), and not a successor to gfx90a, which would still have GDS, I believe.

OK, so only gfx90a and gfx94x lack GDS.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156713/new/

https://reviews.llvm.org/D156713