[PATCH] D156502: [TableGen][NFC] Group tokens with same attribute togather

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added a comment.

This LGTM, thanks.

I have noticed that the "unclustered" values are still not grouped together. I thought it was a matter of just the few I mentioned in my first comment but apparently there are more.

I would have ordered the enum as { unclustered, group1, group2, ....}, just because it would have make it easier to find the cluster. But this is really debatable as it is my personal preference, no need to change it if you do not want to.

Thanks!

Francesco



================
Comment at: llvm/lib/TableGen/TGLexer.h:142-150
   TrueVal,
   FalseVal,
 
   // Integer value.
   IntVal,
 
   // Binary constant.  Note that these are sized according to the number of
----------------
same for these? Move them to the "unclustered" section?


================
Comment at: llvm/lib/TableGen/TGLexer.h:160-166
   // Preprocessing tokens for internal usage by the lexer.
   // They are never returned as a result of Lex().
   Ifdef,
   Ifndef,
   Else,
   Endif,
   Define
----------------
same, move them to the unclustered section?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156502/new/

https://reviews.llvm.org/D156502