[PATCH] D156708: AMDGPU: Consider nobuiltin when querying defined libfuncs

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh accepted this revision.
Pierre-vh added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULibFunc.cpp:960
 
-  // check formal with actual types conformance
-  if (F && !F->isDeclaration() &&
-      fInfo.isCompatibleSignature(F->getFunctionType()))
-    return F;
+  if (F->hasFnAttribute(Attribute::NoBuiltin))
+    return nullptr;
----------------
nit: can you add a small not explaining why it's important to respect this attr?
e.g. what happens if we don't respect it? what does this fix?

Note can be here or in the test, doesn't matter, it's just to preserve some context surrounding this change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156708/new/

https://reviews.llvm.org/D156708