[PATCH] D156522: [LLVM] move verification of convergence control to a class template

Tue Aug 1 02:32:43 PDT 2023

c-rhodes added a comment.

In D156522#4549769 <https://reviews.llvm.org/D156522#4549769>, @sameerds wrote:

> In D156522#4549644 <https://reviews.llvm.org/D156522#4549644>, @c-rhodes wrote:
>
>> this broke my build with:
>>
>>   ld.lld-12: error: undefined symbol: llvm::GenericCycle<llvm::GenericSSAContext<llvm::Function> >::contains(llvm::BasicBlock const*) const
>>   >>> referenced by UniformityAnalysis.cpp:72 (/home/culrho01/llvm-project/llvm/lib/Analysis/UniformityAnalysis.cpp:72)
>>   >>>               lib/Analysis/CMakeFiles/LLVMAnalysis.dir/UniformityAnalysis.cpp.o:(llvm::GenericUniformityAnalysisImpl<llvm::GenericSSAContext<llvm::Function> >::usesValueFromCycle(llvm::Instruction const&, llvm::GenericCycle<llvm::GenericSSAContext<llvm::Function> > const&) const)
>>
>> please could you look into it?
>
> It's not obvious to me how this change could affect affect functions defined in GenericCycle. Can you please provide the commit hash that you are building, and the build parameters? I will need to reproduced this locally to make any progress.

I build with `-DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Debug`, I tried static libs (`-DBUILD_SHARED_LIBS=OFF`) and that works so I think you'll be able to reproduce with shared libs.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156522/new/

https://reviews.llvm.org/D156522