[PATCH] D156706: AMDGPU: Simplify and improve sincos matching
Juan Manuel Martinez CaamaƱo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 1 01:53:43 PDT 2023
jmmartinez added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp:1164-1168
+ Sin->replaceAllUsesWith(Call);
+ Sin->eraseFromParent();
+
+ Cos->replaceAllUsesWith(Reload);
+ Cos->eraseFromParent();
----------------
We should also set the debug location for the `Call` to be the one of `Sin`, and the debug locaiton of `Cos` to be the one of `Reload`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156706/new/
https://reviews.llvm.org/D156706
More information about the llvm-commits
mailing list