[PATCH] D156087: [MLIR] Add stage to side effect

Tue Aug 1 01:41:12 PDT 2023

cxy-1993 added a comment.

In D156087#4549716 <https://reviews.llvm.org/D156087#4549716>, @mehdi_amini wrote:

> In D156087#4549709 <https://reviews.llvm.org/D156087#4549709>, @cxy-1993 wrote:
>
>> Regarding May/Must associated with the effect, I believe you are referring to the relationship between memrefs. If that's the case, we will leave this issue to the pass to invoke alias analysis. If it's not, please let me know.
>
> No I wasn't referring to alias analysis (where "May alias"/"Must alias" is important) but to the read/write effects: how do we model an op that may write the full resource, or may not? 
> We can say that conservatively we say "write full" when it may do so, but then you can't use this information for kill the liveness of the entire resource.

I believe that when we say “write full” to a particular resource, this write is certain to occur. Therefore, any writes to this resource before that point can be killed by this operation. If the write is only possible, and we shouldn't explicitly mark it as writing all resources, do you think this approach is feasible?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156087/new/

https://reviews.llvm.org/D156087