[PATCH] D156136: [BPF] Clean up SelLowering

Mon Jul 31 18:35:29 PDT 2023

tamird marked 2 inline comments as done.
tamird added inline comments.

================
Comment at: llvm/test/CodeGen/BPF/many_args1.ll:3
 ; RUN: FileCheck %s < %t1
-; CHECK: too many args
+; CHECK: error: <unknown>:0:0: in function foo i32 (i32, i32, i32): t10: i64 = GlobalAddress<ptr @bar> 0 too many arguments

----------------
chapuni wrote:
> tamird wrote:
> > chapuni wrote:
> > > This doesn't match in -Asserts.
> > > 
> > > ```
> > > error: <unknown>:0:0: in function foo i32 (i32, i32, i32): 0x55cf2d9bbd90: i64 = GlobalAddress<ptr @bar> 0 too many arguments
> > > ```
> > Sorry about that. I haven't been able to reproduce the failure. What cmake flags are you seeing the failure with?
> Have you tried `CMAKE_ENABLE_ASSERTIONS=OFF`?
Thanks, I thought it defaulted to off. D156769.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156136/new/

https://reviews.llvm.org/D156136