[PATCH] D156087: [MLIR] Add index to side effect

Mon Jul 31 17:54:49 PDT 2023

cxy-1993 added a comment.

In D156087#4549079 <https://reviews.llvm.org/D156087#4549079>, @mehdi_amini wrote:

> I still think documentation is missing, I don't see a definition of "Stage" yet?

When I first implemented it, I added a member variable in this class, but during the discussion with Alex Zinenko, he thought using properties would be more appropriate. What do you think about this issue? Looking forward to your reply.

I

Relate disscussion: https://discourse.llvm.org/t/rfc-add-effect-index-in-memroy-effect/72235/4

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156087/new/

https://reviews.llvm.org/D156087