[PATCH] D154695: [Coroutines] Add an O(n) algorithm for computing the cross suspend point information.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 17:25:18 PDT 2023


MatzeB added a comment.

We're seeing crashes in our builds where `clang -flto=thin` seems to produce IR that cannot be loaded anymore:

  Stderr: Instruction does not dominate all uses!
    %47 = getelementptr inbounds %_ZN5folly8channels6detail22TransformProcessorBaseIN8facebook6falcon6client18FalconNotificationENS5_10BlobEntityENS5_29FalconClientEntityTransformerIS7_NS5_25FalconTransformerSettingsILb0ELb0ELb0EEEEEE13processValuesENS1_5QueueINS_3TryIS6_EEEE.Frame, ptr %0, i64 0, i32 3, i32 0, i32 1
    store i64 %70, ptr %47, align 8, !dbg !220318, !tbaa !81281
  Instruction does not dominate all uses!

Unfortunately it seems to be indeterministic (so it's hard to 100% blame this change, but given all our errors happen with load/stores from `xxx.Frame` types this seemed likely). I'm unfortunately also not seeing any reports from ASAN that would explain the indeterminism.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154695/new/

https://reviews.llvm.org/D154695



More information about the llvm-commits mailing list