[Diffusion] rG76c22b18eafd: [FPEnv][AMDGPU] Correct strictfp tests.

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added a comment.

As is mentioned in D67839 <https://reviews.llvm.org/D67839>, there is a concern about architecture-specific intrinsics that perform floating-point operations. I think it's better to simply require the attribute on all intrinsics rather than try to figure out which ones need it and which ones don't. Since downstream consumers of LLVM IR can add their own intrinsics, it's not even possible in principle to have a comprehensive list of those which need the strictfp attribute.

That said, if we had a separate fpenv-access attribute as @arsenm is suggesting, we could eliminate the requirement to have the strictfp attribute on any intrinsic that doesn't have that attribute. That would make sense to me.


BRANCHES
  main

Users:
  kpn (Author)
  arsenm (Auditor)

https://reviews.llvm.org/rG76c22b18eafd