[PATCH] D156666: Intrinsics: Add type overload to stacksave and stackstore

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3910
+    Value *StackAddr = Builder.CreateIntrinsic(Buf.getPointer()->getType(),
+                                               Intrinsic::stacksave, {});
     Address StackSaveSlot = Builder.CreateConstInBoundsGEP(Buf, 2);
----------------
efriedma wrote:
> Why not CreateStackSave?  (same question for CGDecl.)
I was considering possible multiple stack handling or something, where you'd want to use the current instance's type. It shouldn't matter in reality


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156666/new/

https://reviews.llvm.org/D156666