[PATCH] D156742: [BOLT][DWARF] Fix handling inlined subroutine with no output pc.

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added inline comments.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:868
         consumeError(RangesOrError.takeError());
+      } else if (OutputRanges.empty()) {
+        if (RangesOrError.get().front().LowPC)
----------------
maksfb wrote:
> The condition is always `true` here.
Remove unnecessary check.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:872
+                    "DW_AT_low_pc to address in output binary\n";
+        OutputRanges.push_back({0, RangesOrError.get().front().HighPC});
       }
----------------
Do we expect such range to be ignored by DWARF consumers? Why not push `{0, 0}` or `{0, 1}` then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156742/new/

https://reviews.llvm.org/D156742