[PATCH] D156742: [BOLT][DWARF] Fix handling inlined subroutine with no output pc.

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 14:29:08 PDT 2023


maksfb added inline comments.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:842
     case dwarf::DW_TAG_catch_block: {
-      uint64_t RangesSectionOffset = RangesSectionWriter.getEmptyRangesOffset();
+      uint64_t RangesSectionOffset = 0;
       Expected<DWARFAddressRangesVector> RangesOrError =
----------------
Why is this change needed?


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:868
         consumeError(RangesOrError.takeError());
+      } else if (OutputRanges.empty()) {
+        if (RangesOrError.get().front().LowPC)
----------------
The condition is always `true` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156742/new/

https://reviews.llvm.org/D156742



More information about the llvm-commits mailing list