[PATCH] D156666: Intrinsics: Add type overload to stacksave and stackstore

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

This seems generally reasonable.



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3910
+    Value *StackAddr = Builder.CreateIntrinsic(Buf.getPointer()->getType(),
+                                               Intrinsic::stacksave, {});
     Address StackSaveSlot = Builder.CreateConstInBoundsGEP(Buf, 2);
----------------
Why not CreateStackSave?  (same question for CGDecl.)


================
Comment at: clang/lib/CodeGen/CGDecl.cpp:1631
         Address Stack =
             CreateTempAlloca(Int8PtrTy, getPointerAlign(), "saved_stack");
 
----------------
Does this CreateTempAlloca call need to be updated?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156666/new/

https://reviews.llvm.org/D156666