[PATCH] D153638: [CodeGenPrepare][NFC] Update the dominator tree instead of rebuilding it

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 13:05:31 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:6173
+            NewBaseInsertBB = SplitEdge(NewBaseInsertBB,
+                                        Invoke->getNormalDest(), &getDT(), LI);
             NewBaseInsertPt = NewBaseInsertBB->getFirstInsertionPt();
----------------
This is a bit unfortunate, would be better if SplitEdge accepted DTU. But it looks like that would take a larger refactoring.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153638/new/

https://reviews.llvm.org/D153638



More information about the llvm-commits mailing list