[PATCH] D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation

Paul Osmialowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 13:01:07 PDT 2023


pawosm01 marked an inline comment as done.
pawosm01 added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:133
+cl::opt<unsigned> FPAssociationUpperLimit(
+    "licm-fpassociation-upper-limit", cl::init(5U), cl::Hidden,
+    cl::desc(
----------------
paulwalker-arm wrote:
> Up to you but I think "licm-max-num-fp-reassociations" or "licm-fp-reassociation-cap" would be more in keeping with the existing naming of licm options.
yes, "licm-max-num-fp-reassociations" seems a better name for an option.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152281/new/

https://reviews.llvm.org/D152281



More information about the llvm-commits mailing list