[PATCH] D156589: [RISCV] Add a common base class for RVInstI variations. NFC

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 12:39:26 PDT 2023


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

Thanks, I think this is overall better. I'd thought that having other top-level classes with explicit Inst{...} assignments might be easier to follow, but this patch demonstrates how that incentivises people to inherit from RVInstI and assign imm12 which isn't particularly easy to review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156589/new/

https://reviews.llvm.org/D156589



More information about the llvm-commits mailing list