[PATCH] D156713: [AMDGPU][RFC] Add a target feature for GDS

Brian Sumner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 10:08:43 PDT 2023


b-sumner added a comment.

In D156713#4547505 <https://reviews.llvm.org/D156713#4547505>, @arsenm wrote:

> In D156713#4547504 <https://reviews.llvm.org/D156713#4547504>, @b-sumner wrote:
>
>> In D156713#4547434 <https://reviews.llvm.org/D156713#4547434>, @foad wrote:
>>
>>> Do we want a separate GWS feature? Or a combined "hasGDSAndGWS" feature?
>>
>> We do need a feature that include GWS.  GDS was dropped before GWS in GFX9, but compute never used GDS.  So GDSandGWS would probably work.
>
> I didn't realize GDS was dropped in gfx9, should split the two then

Sorry for mangling this.  GDS was dropped in gfx90a.  GWS was not dropped in gfx9.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156713/new/

https://reviews.llvm.org/D156713



More information about the llvm-commits mailing list