[PATCH] D156679: [WIP][AMDGPU][SIInsertWaitcnts] Do not add s_waitcnt when the counters are known to be 0 already

Austin Kerbow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 09:02:45 PDT 2023


kerbowa added a comment.

We need to be completely sure that the removed waitcnt added by the memory legalizer is a noop and shall not be impacted later in the pass by hoisted waitcnt or merged brackets. As is this patch may cause unexpected and hard to debug errors. In principle, it should be fine to remove waitcnt if we can be sure that the counter is guaranteed to be 0.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156679/new/

https://reviews.llvm.org/D156679



More information about the llvm-commits mailing list