[PATCH] D156477: [RISCVRVVInitUndef] Remove implicit single use assumption for IMPLICIT_DEF

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 08:56:29 PDT 2023


reames updated this revision to Diff 545696.
reames added a comment.

Change was reverted due to a sanitizer failure - thanks!

It turns out the DeadLaneDetector does an out of bounds access if you query a vreg which didn't exist at population, and there's no clean interface to update it.  For the moment, simply avoid querying newly inserted vregs.

This seems worthy of re-review.  @craig.topper thoughts?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156477/new/

https://reviews.llvm.org/D156477

Files:
  llvm/lib/Target/RISCV/RISCVRVVInitUndef.cpp
  llvm/test/CodeGen/RISCV/rvv/undef-earlyclobber-chain.ll
  llvm/test/CodeGen/RISCV/rvv/undef-earlyclobber-chain.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156477.545696.patch
Type: text/x-patch
Size: 9826 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230731/c882e9ea/attachment.bin>


More information about the llvm-commits mailing list