[PATCH] D156603: [SymbolSize] Improve the performance of SymbolSize computation

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 08:47:58 PDT 2023


steven_wu added inline comments.


================
Comment at: llvm/lib/Object/SymbolSize.cpp:89
+  // the same address, give both the same size. Because Addresses is sorted,
+  // using two pointers to keep track of the current symbol vs. the next symbol
+  // that doesn't have the same address for size computation.
----------------
jhenderson wrote:
> Post commit nit "using" -> "use"
Fixed. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156603/new/

https://reviews.llvm.org/D156603



More information about the llvm-commits mailing list