[PATCH] D156696: AMDGPU: Add more tests for sincos recognition

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/amdgpu-simplify-libcall-sincos.weak.ll:6
+
+declare extern_weak float @_Z3sinf(float noundef)
+declare extern_weak float @_Z3cosf(float noundef)
----------------
These should probably be weak definitions, not sure if you're supposed to builtin recognize weak definitions


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156696/new/

https://reviews.llvm.org/D156696