[PATCH] D156682: AMDGPU: Partially respect nobuiltin in libcall simplifier

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds accepted this revision as: sameerds.
sameerds added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp:495
   Function *Callee = aCI->getCalledFunction();
-  if (!Callee)
+  if (!Callee || aCI->isNoBuiltin())
     return false;
----------------
sameerds wrote:
> This seems to ignore `nobuiltin` if a callee is present, but the documentation for `nobuiltin` seems to say something different. Should the short-circuiting OR be swapped here?
Oh wait. I am reading this wrong. Sorry!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156682/new/

https://reviews.llvm.org/D156682