[PATCH] D156678: AMDGPU: Refactor libcall simplify to help with future refined fast math flag usage

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp:642
+    case AMDGPULibFunc::EI_ROOTN:
+      return fold_rootn(CI, B, FInfo);
+    case AMDGPULibFunc::EI_SQRT:
----------------
For consistency with the rest of the `fold_*` functions, shouldn't `fold_rootn` take an `FPMathOperator`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156678/new/

https://reviews.llvm.org/D156678