[PATCH] D156502: [TableGen][NFC] Group tokens with same attribute togather

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 03:54:06 PDT 2023


fpetrogalli added inline comments.


================
Comment at: llvm/lib/TableGen/TGLexer.h:73
+
+  Bit,
+  Bits,
----------------
Why are `Bit` to `TrueKW` excluded from classification? If they cannot be clustered together, I think it would make sense to move them down to the bottom of the struct, so that that the closing of a group with `*LAST` would be followed directly by a `*START` of a new group.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156502/new/

https://reviews.llvm.org/D156502



More information about the llvm-commits mailing list