[PATCH] D156538: [AArch64] Try to combine FMUL with FDIV

Mon Jul 31 01:07:59 PDT 2023

jaykang10 added a comment.

> Oh I see, I hadn't spotted performFDivCombine. It was the scalar patterns I was thinking about, via IntegerToFP and fixedpoint_f32_i32 and SelectCVTFixedPosOperand.

Ah, sorry, I thought you mentioned the `performFDivCombine` function because I was not able to find the custom lowering code for FDIV except SVE.

> Does it make sense to keep them selection fdiv, or should they always just match fmul? It would seem we only need one, and fmul is more canonical.

If possible, I would like to keep the existing `fdiv` pattern in this patch.
I saw @samtebbs changed the `SelectCVTFixedPosOperand` function so I added him as a reviewer and if possible, I would like to get his opinion too.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156538/new/

https://reviews.llvm.org/D156538