[PATCH] D156315: [RFC][GlobalISel] Overhauled MIR Patterns Support for Combiners

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added inline comments.


================
Comment at: llvm/utils/TableGen/GlobalISelCombinerMatchTableEmitter.cpp:1902
+    unsigned NumAlts = 0;
+    // Note: technically, AnyOpcodePattern also needs permutations, but:
+    //    - We only allow a single one of them in the root.
----------------
Note here too, I'm not sure if I should just do everything in terms for permutations.
I special-cased `wip_match_opcode` for now because it can only ever be the root pattern, but there might be value in making everything follow the same pattern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156315/new/

https://reviews.llvm.org/D156315