[PATCH] D149095: [llvm-objdump] Support CHPE code ranges in disassembler.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

No real objections from me to the latest version. I'll put a LGTM, but it should get reviewed by someone more familiar with CHPE and related things before you land it.



================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1433
+        for (uint32_t i = 0; i < CHPEMetadata->CodeMapCount; ++i) {
+          if ((CodeMap[i].StartOffset & 3) != CHPE_RANGE_AMD64 ||
+              !CodeMap[i].Length)
----------------
It might be worth either replacing the "3" literal here and below with a named constant, or at least adding a comment explaining why "3" for those not familiar with the area.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149095/new/

https://reviews.llvm.org/D149095