[PATCH] D156103: [AMDGPU][NFC] Add True16 operand definitions.

Fri Jul 28 11:59:11 PDT 2023

Joe_Nash added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/VOP2Instructions.td:406
 def VOP_MADMK_F16 : VOP_MADMK <f16>;
 def VOP_MADMK_F16_t16 : VOP_MADMK <f16> {
   let IsTrue16 = 1;
----------------
kosarev wrote:
> Joe_Nash wrote:
> > Shall this be renamed to include fake16? I guess a distinct true16 version will be added at a later point.
> Should be split into real and fake definitions later when there's immediate need for that.
But this *Is* the fake version, and when merged with the true16 version downstream both will exist. So I think it makes sense to rename immediately.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156103/new/

https://reviews.llvm.org/D156103