[PATCH] D156103: [AMDGPU][NFC] Add True16 operand definitions.

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev marked an inline comment as done.
kosarev added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/VOP2Instructions.td:381
 def VOP_MADAK_F16 : VOP_MADAK <f16>;
 def VOP_MADAK_F16_t16 : VOP_MADAK <f16> {
   let IsTrue16 = 1;
----------------
Joe_Nash wrote:
> Shall this be renamed to include fake16? I guess a distinct true16 version will be added at a later point.
Should be split into real and fake definitions later when there's immediate need for that.


================
Comment at: llvm/lib/Target/AMDGPU/VOP2Instructions.td:406
 def VOP_MADMK_F16 : VOP_MADMK <f16>;
 def VOP_MADMK_F16_t16 : VOP_MADMK <f16> {
   let IsTrue16 = 1;
----------------
Joe_Nash wrote:
> Shall this be renamed to include fake16? I guess a distinct true16 version will be added at a later point.
Should be split into real and fake definitions later when there's immediate need for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156103/new/

https://reviews.llvm.org/D156103