[PATCH] D156451: GVNSink: port some tests from MergedLoadStoreMotion
Ramkumar Ramachandra via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 28 06:44:44 PDT 2023
artagnon added inline comments.
================
Comment at: llvm/test/Transforms/GVNSink/no-barrier-store.ll:33
+; CHECK: if.end:
+; CHECK-NEXT: ret void
+;
----------------
nikic wrote:
> Contrary to the intent of the test, no actual sinking occurs here. (The previous hand-written check lines were broken and accepted the result either way. Prime example of why hand-written check lines are no longer allowed.)
Sorry for not spotting this. I'll remove this test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156451/new/
https://reviews.llvm.org/D156451
More information about the llvm-commits
mailing list