[PATCH] D156451: GVNSink: port some tests from MergedLoadStoreMotion

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 05:49:03 PDT 2023


nikic added inline comments.


================
Comment at: llvm/test/Transforms/GVNSink/no-barrier-store.ll:33
+; CHECK:       if.end:
+; CHECK-NEXT:    ret void
+;
----------------
Contrary to the intent of the test, no actual sinking occurs here. (The previous hand-written check lines were broken and accepted the result either way. Prime example of why hand-written check lines are no longer allowed.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156451/new/

https://reviews.llvm.org/D156451



More information about the llvm-commits mailing list