[PATCH] D155485: Retain all jump table range checks when using BTI.

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 06:40:07 PDT 2023


simon_tatham updated this revision to Diff 544744.
simon_tatham edited the summary of this revision.
simon_tatham added a comment.

Thanks for the review. New version addressing all those comments (I think):

Switched to finding the current module via `CurMF` as suggested.

Added @chill's suggestion of checking for a function attribute that overrides the module flag, and added some cases of that to the tests.

Added a file-header comment in the test, and zsh-proofing quotes in the sed commands.

Reworded the commit message to explicitly mention `CC_JumpTable`, and also to talk about branch instructions that do/don't require a BTI at their destination, instead of the more low-level terminology of whether they 'set the BTI flag'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155485/new/

https://reviews.llvm.org/D155485

Files:
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/test/CodeGen/Thumb2/jump-table-bti.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155485.544744.patch
Type: text/x-patch
Size: 8062 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230727/37aaaab3/attachment.bin>


More information about the llvm-commits mailing list