[PATCH] D155485: Retain all jump table range checks when using BTI.

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 02:41:45 PDT 2023


chill added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:11325
+        if (FallthroughUnreachable &&
+            !CurMBB->getBasicBlock()->getModule()->getModuleFlag(
+                "branch-target-enforcement"))
----------------
MaskRay wrote:
> `CurMF->getMMI().getModule()->getModuleFlag(` is more common to get `Module`.
We likely need to check the for a function attribute, c.f https://github.com/llvm/llvm-project/blob/efa43d785ee600ef4cc14589e4777264f0613ec9/llvm/lib/Target/ARM/ARMMachineFunctionInfo.cpp#L16



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155485/new/

https://reviews.llvm.org/D155485



More information about the llvm-commits mailing list