[PATCH] D153258: AMDGPU: Optimize set_rounding if input is known to fit in 2 bits

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 03:57:15 PDT 2023


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:3618
+      SDValue BitTable = DAG.getConstant(
+        AMDGPU::FltRoundToHWConversionTableStandardOnly, SL, MVT::i32);
 
----------------
This is just `AMDGPU::FltRoundToHWConversionTable & 0xFFFF` isn't it? I'm not sure it's worth having all the boilerplate in `SIModeRegisterDefaults.cpp` to define another table.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153258/new/

https://reviews.llvm.org/D153258



More information about the llvm-commits mailing list