[PATCH] D153258: AMDGPU: Optimize set_rounding if input is known to fit in 2 bits

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added a comment.

Did you run adequate testing on this (OCL conformance maybe?) ? If so then I can approve it I think



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:3628-3629
 
-    SDValue TableValue =
-      DAG.getNode(ISD::SRL, SL, MVT::i64, BitTable, RoundModeTimesNumBits);
-    SDValue TruncTable = DAG.getNode(ISD::TRUNCATE, SL, MVT::i32, TableValue);
+      // TODO: SimplifyDemandedBits on the setreg source here can likely reduce
+      // the table extracted bits into inline immediates.
+    } else {
----------------
Does that take a lot of effort to add? Why not add it now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153258/new/

https://reviews.llvm.org/D153258