[PATCH] D156349: [DAG] Support store merging of vector constant stores

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 10:48:47 PDT 2023


reames created this revision.
reames added reviewers: craig.topper, nadav, RKSimon.
Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, bollu, simoncook, johnrusso, rbar, asb, hiraditya, arichardson, mcrosier.
Herald added a project: All.
reames requested review of this revision.
Herald added subscribers: wangpc, MaskRay.
Herald added a project: LLVM.

Ran across this when making a change to RISCV memset lowering.  Seems very odd that manually merging a store into a vector prevents it from being further merged.

p.s. I'm making this depend on the RISCV mem* lowering, but this could easily be rebased off that change set.  If reviewers would prefer to separate, let me know.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156349

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/test/CodeGen/RISCV/rvv/memset-inline.ll
  llvm/test/CodeGen/X86/MergeConsecutiveStores.ll
  llvm/test/CodeGen/X86/avx512-mask-op.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156349.544436.patch
Type: text/x-patch
Size: 15186 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230726/42d0bcab/attachment.bin>


More information about the llvm-commits mailing list