[PATCH] D156287: [RISCV] Add codegen support for bf16 vector

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 09:35:29 PDT 2023


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:6695
+
+let Predicates = [HasStdExtZvfbfwma] in {
+defm PseudoVFWMACCBF16  : VPseudoVWMAC_VV_VF_BF_RM;
----------------
craig.topper wrote:
> Putting the predicate on the instruction only affects the assembler, but these are pseudos so the assembler doesn't matter. The Predicate needs to be on the pattern.
They're helpful for documenting what pseudos are available though (and I believe affect the machine verifier?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156287/new/

https://reviews.llvm.org/D156287



More information about the llvm-commits mailing list