[PATCH] D154695: [Coroutines] Add an O(n) algorithm for computing the cross suspend point information.

[witstorm via Phabricator via llvm-commits]

witstorm95 updated this revision to Diff 544191.
witstorm95 added a comment.

@ChuanqiXu I have refactor it again as your suggestions. Some redundant operation has been removed.

I have tested folly library again and enabled coro tests(experimental/coro/test). The results are the same before and after this patch. But there still exists some fail. Here are the failed cases:

  245 - heap_vector_types_test.HeapVectorTypes.GrowthPolicy (Failed)
  1362 - HHWheelTimerTest.HHWheelTimerTest.FireOnce (Failed)
  1366 - HHWheelTimerTest.HHWheelTimerTest.CancelTimeout (Failed)
  1368 - HHWheelTimerTest.HHWheelTimerTest.SlowFast (Failed)
  1369 - HHWheelTimerTest.HHWheelTimerTest.ReschedTest (Failed)
  1371 - HHWheelTimerTest.HHWheelTimerTest.DefaultTimeout (Failed)
  1375 - HHWheelTimerTest.HHWheelTimerTest.IntrusivePtr (Failed)
  1376 - HHWheelTimerTest.HHWheelTimerTest.GetTimeRemaining (Failed)
  1378 - HHWheelTimerTest.HHWheelTimerTest.Level1 (Failed)
  1487 - lang_exception_test.ExceptionTest.terminate_with_direct (Failed)
  1488 - lang_exception_test.ExceptionTest.terminate_with_variadic (Failed)
  3016 - coro_asyncscope_test.AsyncScopeTest.DontThrowOnJoin (Failed)
  3078 - coro_async_scope_test.AsyncScopeTest.DontThrowOnJoin (Failed)
  3090 - coro_async_stack_test.AsyncStackTest.MixedStackWalk (SEGFAULT)

As you can see, some coro tests failed. Do you know the problem ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154695/new/

https://reviews.llvm.org/D154695

Files:
  llvm/lib/Transforms/Coroutines/CoroFrame.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154695.544191.patch
Type: text/x-patch
Size: 9713 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230726/3070b80e/attachment.bin>