[PATCH] D156171: [AArch64][GlobalISel] G_FMINNUM and G_FMAXNUM vector lowering

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 14:56:19 PDT 2023


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM, thanks.



================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:930-934
+      .minScalarOrElt(0, MinFPScalar)
+      .clampNumElements(0, v4s16, v8s16)
+      .clampNumElements(0, v2s32, v4s32)
+      .clampNumElements(0, v2s64, v2s64)
+      .moreElementsToNextPow2(0);
----------------
General musing out loud, not for this patch: we should find a way to factor out these common vector rules cleanly. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156171/new/

https://reviews.llvm.org/D156171



More information about the llvm-commits mailing list